XSG-12273
Locked airport ceased to be locked after being updated to gateway
Bug report
Reported by:
b787
on September 9, 2021 10:55 AM
Assigned to:
Julian Lockwood
Recently, I locked an airport to work with it. After 3 lock extensions, and with time before the expiration date, I update the scenery, showing it as accepted (not approved or declined yet). I though this will cease the lock count against me, but the scenery will remain locked for everybody until it is approved or declined, when I should unlock it, as I understand from Julian words:
"The solution is to not tally airports that are waiting ‘in limbo’. This means as soon as you submit your airport, it is no longer tallied against your lock total (but is still locked in an absolute sense, and therefore cannot be claimed by another artist). One thing to be aware of – when an airport becomes approved or declined, it ceases to be in limbo, and WILL be tallied against an artist’s lock count. It’s important therefore to manually release locks that are in effect, but no longer needed."
https://developer.x-plane.com/2021/06/locking-airports-on-the-gateway/
But, I was surprised when the expiration date arrived, and now the airport is unlocked (and I can't lock it during 30 days). Is this how it should work and I misunderstood that blog? or there is something not working as intended?
The airport is LEMD btw
Julian Lockwood September 9, 2021 4:15 PM
Wait .. the lock isn’t counted against the artist’s tally, but it can still expire. I don’t think we made any provisions to protect from that happening, but probably we SHOULD. Like - if the submission is pending moderation ('Uploaded' or ‘Accepted’), the lock should not time out UNTIL the submission changes to another status.
b787 September 10, 2021 11:34 AM
Well, in that case, I totally agree. That could prevent some issues if someone start working in an airport that is not yet moderated.
Thank you
Albino Santos October 15, 2021 11:47 PM
I can confirm, the lock still expire for airports waiting ‘in limbo’, and can't extend expiration date.
Jan Vogel October 26, 2021 5:33 AM
From reading this I think the problem is: Airport that take a long time to be moderated may exceed their “locked” duration and become unlocked again…so another user can pick it (the previously recommended version) up and start working “in parallel”. So eventually we could end up with two (or more) versions uploaded and waiting for moderation.
This will only happen if a.) moderation takes longer than the remaining “lock duration” and b.) the second artist fails to check the airport page on the Gateway (and fails to spot that a new version is awaiting moderation).
To fix this we need to establish functionality that keeps the airport “locked” while it waits for moderation, even if this means extending the locking period beyond what would normally be allowed.
Daniela Rodríguez Careri October 26, 2021 12:31 PM
I think it’s a good idea. Let’s implement it.
Daniela Rodríguez Careri October 26, 2021 5:48 PM
Guille and I were thinking that fiddling with the checkout dates would complicate the logic that determines when a checkout is active or not. The problem we’re trying to solve here is not strictly lock-related: we’re trying to stop artists to lock an airport that has work pending moderation. So we can implement exactly that: if an airport has any scenery with status “uploaded” or “accepted”, it cannot be locked, independently of current locks on it and their status. Agree? @Julian @Litjan
Julian Lockwood October 26, 2021 6:08 PM
@danita Yes absolutely agree .. this seems the right way to solve this problem !
Daniela Rodríguez Careri October 27, 2021 12:51 PM
Deployed on PRODUCTION
Julian Lockwood October 27, 2021 6:03 PM
@danita Super .. thanks Dani !!!